fixes for Efield after renaming LM to LMeX #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchdf
approved these changes
Oct 13, 2023
|
Well shoot maybe all that renaming was a bad idea? |
|
Gonna merge this now and add the test coverage in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #257 when file names were changed from LM to LMeX some of the Efield related file name changes were missed, due to lack of test coverage for Efield capability. This PR gets the Efield cases working, other than
PremBunsen3DKuhl, which relies on a mechanism that doesn't exist in PelePhysics.TODO: